Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment CA Bundle resolution #6074

Merged
merged 1 commit into from
Feb 26, 2022

Conversation

nateprewitt
Copy link
Member

This is a proposal to address #6071. Rather than settling on the final value from CURL_CA_BUNDLE we'll end the conditional change with verify. This ensures we don't accidentally take a "falsey" value and disable verification for misconfigured environments.

@sigmavirus24 sigmavirus24 merged commit 79f6027 into psf:main Feb 26, 2022
@nateprewitt nateprewitt deleted the curl_ca_bundle branch February 26, 2022 13:42
@nateprewitt nateprewitt added this to the 2.28.0 milestone Apr 7, 2022
@nateprewitt nateprewitt mentioned this pull request Jun 8, 2022
@RafalSkolasinski
Copy link

So... we considered this a feature and not a bug. How can we control verify=False through environmental variables now?

@RafalSkolasinski
Copy link

RafalSkolasinski commented Jul 25, 2022

Use case when call of requests api is buried deep in the dependency stack and you need to force verify=False

@psf psf locked and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CURL_CA_BUNDLE= disables certificate verification
3 participants